From: Maynard J. <may...@us...> - 2008-05-20 01:59:45
Attachments:
differential_profile.patch
|
In John's reply to my suggestion of putting out a new release, he indicated he wanted bug 1820202 fixed ("differential profile broken in 0.9.3"). As I mentioned in my May 16 posting, I did some testing of 0.9.3 and found my differential profile report testing resulted in 0% difference for a function where the two individual reports showed a significant change. Testing the same scenario with current CVS code, I get the error message "error: no sample files found: profile specification too strict ?". Testing the same scenario with 0.9.1 gave expected results. The specific command I used with current CVS code to the the "specification too strict" error was: opreport -l ./my_testcase { archive:./orig } { } If I removed the image specification from the above command, I actually got a correct differential profile report. I found a bug in libpp/profile_spec.cpp in how it was handling image specifications for a profile spec that had a non-null archive path. The image spec file list was being processed (and "fixup" attempted) before the archive path was established on the profile_spec's extra_found_images member. The attach patch changes profile_spec::create so that it puts the image spec files in a temporary container when first parsing the passed input; then, after the archive path is established, put the image spec files into the image_or_lib_image container via the routine that fixes up the path to include the archive path. Regards, -Maynard |
From: John L. <le...@mo...> - 2008-05-20 14:31:51
|
On Mon, May 19, 2008 at 08:59:17PM -0500, Maynard Johnson wrote: > retrieving revision 1.35 > diff -p -a -u -r1.35 profile_spec.cpp > --- libpp/profile_spec.cpp 28 Apr 2008 21:23:22 -0000 1.35 > +++ libpp/profile_spec.cpp 20 May 2008 01:38:22 -0000 > @@ -303,6 +303,7 @@ profile_spec profile_spec::create(list<s > { > profile_spec spec; > set<string> tag_seen; > + std::vector<std::string> temp_image_or_lib; Don't need std:: here. Looks fine otherwise regards john |