From: John Levon <levon@mo...> - 2002-01-11 20:07:04
On Fri, Jan 11, 2002 at 10:15:31AM -0800, Philippe Elie wrote:
> +/* FIXME: John you use 2.3.21, I prefer 2.2.20, it is worthwhile to try to
> + * support obsolete development kernel, from now just support the 2.5 and drop
> + * the 2.3 support ?. The state is actually we compile from 2.2.0 to 2.2.20 UP
> + * and from 2.2.8 to 2.2.20. !CONFIG_X86_LOCAL_APIC do not compile see later
> + * in this file*/
> +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,2,8) && defined(CONFIG_SMP)
> +/* Note than theorically we can support SMP when < 2.2.8 but that's worthwhile,
> + * we need a working smp_call_function() which is not obvious to provide */
> +#error "unsupported configuration: kernel < 2.2.8 must be compiled as UP to create a working oprofile"
prefer configure, this will do for now.
> +/* FIXME: John, the intent of __SMP__ is to pass it to kernel header not
> + * to use it, 2.2 always declare correctly CONFIG_SMP but the 2.2 headers are
> + * broken and in a few place use __SMP__. Replace this by CONFIG_SMP ? */
ok, thanks for the info
> /* FIXME: consider apic_up_compat ... */
> +/* John 2.4.0 #ifndef CONFIG_X86_LOCAL_APIC #include "apic_up_compat.h" #endif
> + * do not work because we get redefinition about APIC_BASE. I let this left for
> + * now, currently I get no prototype for apic_read/apic_write when
> + * !CONFIG_X86_LOCAL_APIC */
ok. btw, the apic setup is seriously broken on 2.2, even when we add the proper fixmap
code back in.
> +/* FIXME PHE to myself I suspect something wrong here look bttv.c */
this might be a factor :)
"They're all fools. Don't worry. Darwin may be slow, but he'll eventually get
- Matthew Lammers
From: Dave Jones <davej@su...> - 2002-01-11 20:14:57
On Fri, 11 Jan 2002, John Levon wrote:
> ok. btw, the apic setup is seriously broken on 2.2, even when we add the proper fixmap
> code back in.
btw, I'm curious.. why the sudden activity to get it working on 2.2 ?
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
From: Philippe Elie <ph_e@cl...> - 2002-01-11 21:26:44
> On Fri, 11 Jan 2002, John Levon wrote:
> > ok. btw, the apic setup is seriously broken on 2.2, even when we add the proper fixmap
> > code back in.
> btw, I'm curious.. why the sudden activity to get it working on 2.2 ?
A friend have requested that and I think he is not the only people
in this case. He work in a laboratory on a 2.2 and the sys admin worry
about upgrade just for one application. Think in term of end-user
rather of kernel hacker, user don't want to reinstall a kernel too many
time, that's just a loss of time
Also I think it is not bad for oprofile to remove as restriction of use as
we can. After porting to 2.2 and adding the RTC patch it can be used
nearly on the most used kernel version and the most used hardware.