Re: [PATCH] Fix debuginfo file processing so we don't require section vmas to match

[William C. <wc...@re...>]

On 10/25/2011 04:52 PM, Maynard Johnson wrote:
> This patch removes an invalid sanity check in bfd_suppport.cpp:translate_debuginfo_syms() that was comparing the section vma of the image file with that of the debuginfo file and requiring them to be the same.  This is not always true.

Hi Maynard,

There were some cases where the order of the sections differed between the executable and the .debug file:

http://oprofile.git.sourceforge.net/git/gitweb.cgi?p=oprofile/oprofile;a=commitdiff;h=36f0d55e1589162bb8dd0aebf51fdc7505ac2c86;hp=f24b6853d62d0603f875d185b129653e0ae307ef

Would it be possible to just flip the SEC_LOAD bit in the .text section of .debug and just avoid translating over to the executable .sections?

-Will
> 
> From f0b4cdfe147e63353792150c0d45e3941343aa96 Mon Sep 17 00:00:00 2001
> From: Maynard Johnson <may...@us...>
> Date: Tue, 25 Oct 2011 15:10:24 -0500
> Subject: [PATCH] Fix debuginfo file processing so we don't require section vmas to match
>  when comparing runtime image to debuginfo file.
> 
> 
> Signed-off-by: Maynard Johnson <may...@us...>
> ---
>  libutil++/bfd_support.cpp |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/libutil++/bfd_support.cpp b/libutil++/bfd_support.cpp
> index 69d6938..eaa0533 100644
> --- a/libutil++/bfd_support.cpp
> +++ b/libutil++/bfd_support.cpp
> @@ -486,10 +486,8 @@ void bfd_info::translate_debuginfo_syms(asymbol ** dbg_syms, long nr_dbg_syms)
>  
>  				range = image_sections.equal_range(sym->section->name);
>  				for (it = range.first; it != range.second; it++) {
> -					if ((*it).second->vma == sym->section->vma) {
> -						matched_section = (*it).second;
> -						break;
> -					}
> +					matched_section = (*it).second;
> +					break;
>  				}
>  			}
>  			if (matched_section) {
> -- 
> 1.6.2.rc2
> 
> 
> 
> 
> 
> ------------------------------------------------------------------------------
> The demand for IT networking professionals continues to grow, and the
> demand for specialized networking skills is growing even more rapidly.
> Take a complimentary Learning@Cisco Self-Assessment and learn 
> about Cisco certifications, training, and career opportunities. 
> http://p.sf.net/sfu/cisco-dev2dev
> 
> 
> 
> _______________________________________________
> oprofile-list mailing list
> opr...@li...
> https://lists.sourceforge.net/lists/listinfo/oprofile-list