Re: [PATCH] enable kernel/user domain profiling for ppc64

[Olof J. <ol...@li...>]

On Tue, Apr 01, 2008 at 05:08:07PM -0500, Chris J Arges wrote:
> This patch enables kernel and/or user domain profiling for ppc64
> architectures. Since ppc64 architectures don't allow one to select
> kernel/user profiling on a per-counter basis, this patch makes sure that
> all specified events have matching per-counter user/kernel flags, and
> uses this to set the domain user/kernel flag
> (/dev/oprofile/enable_kernel and /dev/oprofile/enable_user). The
> checking is done in check_event_mapping_data(), and if any of the flags
> do not match, then the opcontrol script fails. 
> 
> Olof, this patch also affects ppc64/pa6t, and I am unsure if it is
> necessary for that specific architecture. Please let me know if this
> patch should exclude ppc64/pa6t.

Hi, sorry for the delay. Please take out the test for pa6t,
our counters work similar in this manner (i.e. the counting of
hypervisor/supervisor/problem state is global, not per-counter). I've
verified the function of this patch on a board here as well, with the
test removed things work just as expected.


Thanks for fixing this!


-Olof