#64 OProfile doesn't build with 2.4.9

closed-fixed
nobody
None
5
2002-07-25
2002-06-10
William Cohen
No

Some changes in the CVS repository made after June 4,
2002 prevent OProfile from building with a 2.4.9
kernel. According to the documentation Linux 2.4.10
kernels and above are recommended, but it doesn't state
this is required. Below is the tail end of the build log:

gcc -I/lib/modules/2.4.9-21custom/build/include/
-I/home/wcohen/research/profiling/oprofile/oprofile-build.20020609a/
-I/home/wcohen/research/profiling/oprofile/oprofile-build.20020609a/libutil/
-I/home/wcohen/research/profiling/oprofile/oprofile-build.20020609a/libop/
-I.. -D__KERNEL__ -DMODULE -mpreferred-stack-boundary=2
-DEXPECT_OK -DRTC_LOCK -DMODVERSIONS -include
/lib/modules/2.4.9-21custom/build/include/linux/modversions.h
-mcpu=i686 -pipe -O2 -fomit-frame-pointer
-fno-strict-aliasing -Wall -Wstrict-prototypes -Wunused
-Werror -c -o op_fixmap.o op_fixmap.c
cc1: warnings being treated as errors
op_fixmap.c:146: warning: `struct intel_mp_floating'
declared inside parameter list
op_fixmap.c:146: warning: its scope is only this
definition or declaration, which is probably not what
you want.
op_fixmap.c: In function `mpf_table_ok':
op_fixmap.c:148: `SMP_MAGIC_IDENT' undeclared (first
use in this function)
op_fixmap.c:148: (Each undeclared identifier is
reported only once
op_fixmap.c:148: for each function it appears in.)
op_fixmap.c:150: dereferencing pointer to incomplete type
op_fixmap.c:155: dereferencing pointer to incomplete type
op_fixmap.c:155: dereferencing pointer to incomplete type
op_fixmap.c: In function `smp_scan_config':
op_fixmap.c:165: warning: passing arg 1 of
`mpf_table_ok' from incompatible pointer type
make[1]: *** [op_fixmap.o] Error 1
make[1]: Leaving directory
`/home/wcohen/research/profiling/oprofile/oprofile-build.20020609a/module/x86'
make: *** [all] Error 1

The 2.4.9 kernel doesn't define "struct
intel_mp_floating" or "SMP_MAGIC_IDENT".

-Will

Discussion

  • William Cohen
    William Cohen
    2002-06-10

     
    Attachments
  • William Cohen
    William Cohen
    2002-06-10

    Logged In: YES
    user_id=542804

    The problem is caused by the removal of the following line
    from module/compat24.h

    #include <asm/mpspec.h>

    The following patch fixes the problem.

    2002-06-10 Will cohen <wcohen@nc.rr.com>

    module/x86/op_fixmap.c: Add include.

     
  • John Levon
    John Levon
    2002-06-16

    Logged In: YES
    user_id=53034

    This file should be included from apic_compat.h now. Can you
    please
    check ? It can't be included unconditionally because it breaks
    the 2.2 build.

     
  • Philippe Elie
    Philippe Elie
    2002-06-26

    Logged In: YES
    user_id=318973

    I checked build through 2.2.10 to 2.5.19, committing a few fix for
    them. I open a separate bug entry for 2.5.20 and later make error

    Phil

     
  • Philippe Elie
    Philippe Elie
    2002-06-26

    • status: open --> open-fixed
     
  • John Levon
    John Levon
    2002-07-25

    • status: open-fixed --> closed-fixed