#241 JIT dump file is failed to be loaded in opreport.

None
closed-fixed
None
5
2013-07-29
2013-04-11
Ghacker
No

"opreport" is failed to load JIT dump file in session directory when "--root" option is given and the "root directory" doesn't contain the session directory or the JIT dump file(That means "root directory" and "session directory" is totally separated.)

If '--root' is missed or given root directory contains session directory or JIT dump file, it works fine.

Discussion

<< < 1 2 (Page 2 of 2)
  • Ghacker
    Ghacker
    2013-04-17

    I think, your documentation is great.
    Now, I think, I'll be more clear that use of oparchive is necessary when host/target situation.

    But, I still think that there's some more way to make it a little bit more complete.

    1. Documentation
    I think your patch for documentation of oparchive is already enough and great.
    But, if description for session option is mentioned in opreport and opannotate, it'll be better.
    Because, I think not every users are read manual carefully at first sight.
    May be, 'operf' and 'opreport' will be read even at first sight.
    2. Efficiency
    As you told before and written on modified manual, in host/target situation, oparchive still could collect unnecessary data before tar it.
    In other words, oparchive still need more storage and computational resources for unncessary informations.
    Usually, in host/target situation, target has not enough resources.
    (In my case, I'll not tar archive. Because, tar is not ported on android native and I can just pull directories using adb withou tar.)
    If there's an option to control or choose archive target for oparchive, it can reduce such an inefficiency.
    Of couse it should not effect existing behavior when it's not used explicitly.
    3. noticeability
    opreport still can run with wrong information with not enough warning (I thought).
    If wrong information can be detected, it's better to be warned to guide user to read oparchive manual.

    As I said earlier, I don't want to bother you with this.
    But, I just want you to consider my private opinions.

    Again, I thank you very much for your great efforts.

     
    • status: open --> open-fixed
     
  • I committed the doc patch upstream, but first, I removed references to 'tar' (didn't know that utility wasn't available on Android).

    As for description of session-dir, I believe the man pages for opreport and opannotate give a good description of that option.

    As for opreport being executed in such a way that it uses incorrect information or insufficient information and does not give warnings . . . it's very hard to protect against every kind of mis-use of this command, since it has to handle so many different scenarios. But if you find a particular common scenario that you think it should handle, please submit a patch to the oprofile-list, and I'll be happy to review it.

    For now, I'm marking this bug as "Fixed", but it will remain open until the next official release. If you still have issues, you can still add comments to the bug.

     
  • Ghacker
    Ghacker
    2013-04-18

    My concern about documentation and notice might be too much.
    It already seems good enough.
    But, I just didn't sure that it's enough or not for beginners. Because You and I already know that functionality.

    When I'm finding "common scenario" that makes the situation, I'll comment it to this.
    For now, I don't think my secnario is "common scenario"

    Anyways.. Thanks for what you've done with passion.
    As a fan of oprofile, I hope it'll be getting better always.

     
  • Ghacker
    Ghacker
    2013-04-18

    • status: open-fixed --> open
     
    • status: open --> open-fixed
     
    • status: open-fixed --> closed-fixed
    • Group: -->
     
<< < 1 2 (Page 2 of 2)