Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#207 Nr. non-backtrace samples in oprofiled.log is not accurate

closed-fixed
None
7
2012-08-27
2011-12-03
Maynard Johnson
No

The Nr. non-backtrace samples is tracked in the daemon code with opd_stats[OPD_SAMPLES]. This value is incremented every time sfile_find() is called from opd_put_sample(). However, if we're processing samples for which the sfile has already been found, then trans->current will be set, and thus we will not call sfile_find again. In fact, there are several statistics counters managed in sfile_find that should probably be managed from opd_put_sample.

Discussion

  • It turns out that only the OPD_SAMPLES stat was being incremented in the wrong place. The other stats that are incremented in sfile_find() are within if-statements where we could only reach that code if trans.current was NULL in opd_put_samples and we then had to call sfile_find().

    I posted a patch for this problem to the list.

     
    • assigned_to: nobody --> maynardj
     
  • Patch committed on July 20.

     
    • status: open --> open-fixed
     
    • status: open-fixed --> closed-fixed