Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#194 Patch to move from QT3 to QT4[qt3support]

closed-fixed
None
5
2011-08-12
2010-10-20
Gert Wollny
No

It seems that QT3 is outdated and some distributions (like Gentoo) have phased out support for it. With the attached patch the GUI tool is moved to rely on Qt4 by using the qt3 support library. I haven't tested it much, I'm not a Qt expert and there are warnings about not connected signals, although the buttons seem to work like with the QT3 version (i.e. sampling starts stops and the data can be flushed, and the flags selected).

Discussion

<< < 1 2 (Page 2 of 2)
  • Gert Wollny
    Gert Wollny
    2011-01-18

    It seems, on SLES 10 SP2 the Qt3Support .pc doesn't provide the -DQT3_SUPPORT flag as it should and I made an error adding it manually, which I couldn't see, because the flag was set anyway.

    I reviewed the patch to provide more meaningful error messages and set qt3 as the default (i.e. if no enable-gui is given and if --enable-gui is given with yes or without parameter).
    If moc and uic3 are not found by pkg-config or the found files are not executable then configure will bail out with a message that QtCore.pc is most likely buggy. The -DQT3_SUPPORT flag will be set if it is not found.

     
  • Gert, thanks for your diligence. I think we're very close to having a patch that's ready to be reviewed by the wider oprofile community. I'm attaching a marked-up copy of your patch that includes my review comments. Your latest patch works pretty well now in the various scenarios I've tried it on -- with a few minor caveats that I mention in my review comments. It shouldn't take too much effort for you to address my review comments. Once you do, you can either attach the new patch to this bugzilla or post it to the oprofile mailing list and ask for community review -- which is what I'll do if you don't. :-)

     
  • Review of patch

     
  • Gert Wollny
    Gert Wollny
    2011-01-18

    reviewed version of patch against CVS

     
  • Gert Wollny
    Gert Wollny
    2011-01-18

    Well, I've added the things that you commented on. In addition, I changed the handling when the moc_location and uic_location are not given. I noted on Fedore that moc and uic3 can be found in the path, hence I try AC_CHECK_PROG as a fall-back. Since in your first message you indicated that on SLES 10 SP1 the package could configured and I was using AC_CHECK_PROG only at that time, I suspect that this workaround should work there.

     
    • status: open --> open-fixed
     
    • status: open-fixed --> closed-fixed
     
<< < 1 2 (Page 2 of 2)