#185 opcontrol breaks on busybox ash in is_tool_available()

closed-fixed
None
5
2011-08-12
2009-10-14
Patrick Sung
No

I am trying to run oprofile on embedded platform which uses busybox ASH as the default shell.

In opcontrol: is_tool_available(), the line that test "which $1 &>/dev/null" always return true and therefor tools are always available even tho it is not. Changing the line from "which $1 &>/dev/null" to "which $1 > /dev/null 2>&1" fixes it.

Discussion

  • Patrick, sorry this bug has languished for so long with no one looking at it. You didn't squeak loud enough, I guess. Is this still a problem?

     
    • assigned_to: nobody --> maynardj
     
  • Patrick Sung
    Patrick Sung
    2011-05-18

    I believe William Cohen already created a patch, attached to this bug record.

     
  • I reviewed/tested Will's patch and it looks fine. Thanks, Will! I committed the fix to the git repo. Marking bug as "Fixed".

     
    • status: open --> open-fixed
     
    • status: open-fixed --> closed-fixed