Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#359 Frames in the same row with the new renderer

v4.9.1
closed
renderer (19)
5
2014-01-30
2013-07-26
Javier Paniza
No

When two frames (references or groups) are in the same row the frames are too close or even overlapped. See the attached screenshot.

You can test it in Customer modelo of OpenXavaTest

1 Attachments

Discussion

  • Fixed on last post. Please test it on NaviOx to clear this bug.

     
  • Javier Paniza
    Javier Paniza
    2013-08-27

    Hi Federico,

    I tried it in NaviOX and now the frames are not overlapped. OK. I attached the corresponding screenshot.
    However, in the case of NaviOX the space is too small. It would be nice to keep this space coherent with spacing using in the rest of the NaviOX style. So, I tried to modify it and I see that this spacing is setting in hard code, in the method beginFrame() of DefaultLayoutPainter:

    padding-left:4px;
    

    It would be better to move this 4px value to the CSS file, in this way the style designer can modify it to adapt to his style.

    What do you thik?

     
  • Which css entry can I use that keeps the compatibility with the rest of OX's styles?

     
  • Javier Paniza
    Javier Paniza
    2014-01-22

    Hi Federico,

    after removing the style from HTML, I first would try to use an alredy existing class, such as ox-frame. If it does not work you can create a ox-frame-whatever class.

     
  • Hi Javier:

    ox-frame-sibling class was used, since ox-frame applies to the first frame in a row and the other one following.

    In the first frame we might not want a padding-left applied, whereas in the other frames it is a posible setting.

    Please check this behaviour, and close this issue if everything is working out.

    Federico

     
  • Hi Javier:

    Issue should be closed for 4.9.1. Posted in current svn code.

    Federico

     
  • Javier Paniza
    Javier Paniza
    2014-01-30

    • status: open --> closed
    • Group: v4.8.1 --> v4.9.1
     
  • Javier Paniza
    Javier Paniza
    2014-01-30

    Hi Federico,

    yes, it works, so I'll close it. However, I found some little issues:
    1. In NaviOX the right frame is not aligned on the right. I will add a bug for this.
    2. In NaviOX there is a double frame. I think that it affects to all the styles that uses .ox-frame in its CSS. I will add a bug for this.
    3. The .ox-frame-sibling is in the custom.css of OpenXavaTest. Thus the problem is solved for OpenXavaTest only but not for the rest of applications. It's not a good idea to put a standard style in custom.css of OpenXavaTest because you will see OpenXavaTest different than a regular OpenXava application, so you will note deffects. I moved .ox-frame-sibling to portal.css. Is this right? Why do you put it in custom.css?

    The support for NaviOX style is important because I'm going to donate the NaviOX visual style to OpenXava, so the default style for OpenXava 5 will be the current NaviOX style.