Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#47 Allow MI command to return all values under a profile

trunk
closed-accepted
modules (179)
5
2009-02-14
2008-12-31
Richard Revels
No

This is a small patch to check for the value of "all" when using the MI command profile_get_size. We needed it for the case where we want to know how many dialogs are up for each value but did not want to have to run the MI command multiple times.

opensipsctl fifo profile_get_size inbound all

Discussion

  • Richard Revels
    Richard Revels
    2008-12-31

    diff file generated against 1.4 revision 5055

     
    Attachments
  • Richard Revels
    Richard Revels
    2009-01-04

    Added a second patch file which correctly returns all values within each hash rather than just the first one. The next step will be to have the new function return counts rather than calling get_profile_size in a loop.

     
  • Richard Revels
    Richard Revels
    2009-01-04

    fixes problem in first version that didn't iterate hashes

     
    Attachments
  • Ovidiu Sas
    Ovidiu Sas
    2009-01-05

    This patch will make 'all' a restricted value for a profile.
    I would rather have a new mi command for returning all values (like profile_get_vsize).

    Regards,
    Ovidiu Sas

     
  • Hi Richard,

    I agree with Ovidiu - better make a new function to avoid conflicts between values and keyword.

    Regards,
    Bogdan

     
    • assigned_to: nobody --> bogdan_iancu
    • status: open --> open-accepted
     
  • Richard Revels
    Richard Revels
    2009-01-09

    I thought about that and decided it wasn't a problem. Guess I should have thought about it a little more. I was planning to work on an update this weekend. I'll change it to a new function at the same time.

     
  • Richard Revels
    Richard Revels
    2009-01-29

    adds new mi command profile_get_values and fixes memory leak

     
    Attachments
  • Richard Revels
    Richard Revels
    2009-01-29

    Uploaded new diff file. This was also created against 1.4 revision 5055. The patch should be applied after changing to the modules/dialog directory.

    Usage:
    opensipsctl fifo profile_get_values outbound

    Will return list of values assigned to outbound profile with dialog count in each. Also prints summary count of all values.

     
    • milestone: 869101 --> trunk
    • status: open-accepted --> closed-accepted
     
  • Hi Richard,

    The patch is on SVN trunk.

    Thanks and regards,
    Bogdan