Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#227 Correct types of a values in the usrloc module

closed-accepted
nobody
modules (179)
5
2012-07-03
2012-06-14
Peter Lemenkov
No

This patch fixes an issue with a erroneously set types during conversion within the usrloc module.

Discussion

  • Peter Lemenkov
    Peter Lemenkov
    2012-06-14

    Honestly I'm not so sure about this patch. It's clear that vals2[3].type and vals2[4].type doe not match an actual val field used but maybe it's better to change vals2[3].type and vals2[4].type to DB_BITMAP type instead.

     
  • Hello,

    Looking at when the flags and cflags are loaded from DB to OpenSIPS mem, they are fetched as DB_BITMAP, so it would probably be better to also save them as DB_BITMAP to the db.
    Again, this was a small inconsistency, things were working until now since the DB_INT and DB_BITMAP types are treated very similarly in the C code.

    Patch was applied on OpenSIPS trunk

    Thanks and Regards,
    Vlad

     
    • status: open --> closed-accepted