#223 Handle case where reply after engage_mediaproxy has no body

trunk
closed-wont-fix
saghul
modules (179)
5
2012-08-14
2012-05-30
Dynamic Packet
No

Currently if you remove the body via strip_body() of an in-dialog reply which is using engage_mediaproxy() you end up with junk in the body. IT seems the reply is still processed and the lump with the ip and port of the mediaproxy is appended as junk. This patch skips processing the reply if there is no body or it has been removed. Let me know your thoughts Saul and others so we can get this applied to trunk and possibly 1.8.x or even older branches.

Discussion

  • Dynamic Packet
    Dynamic Packet
    2012-05-30

    • labels: --> modules
    • milestone: --> trunk
     
  • saghul
    saghul
    2012-05-30

    As discussed on IRC, the proper fix for this would be as follows:

    Modify the get_sdp_message function (in the mediaproxy module) so that it returns false also when the body was removed with a lump.

     
  • Dynamic Packet
    Dynamic Packet
    2012-05-30

    check for deleted body if message has sdp

     
  • Dynamic Packet
    Dynamic Packet
    2012-05-30

    Attached new patch to check for body being deleted inside get_sdp_message() .

     
    • assigned_to: nobody --> saghul
     
  • saghul
    saghul
    2012-08-14

    • status: open --> closed-wont-fix