#155 base64, sip_uri ob param, msg_cb fix

trunk
open-invalid
core (47)
2
2011-06-30
2010-08-17
Kennard White
No

Two de-coupled changes (sorry):
1. Add functions for base64 encoding and decoding. Encoder was previously in presence module.
2. Add 'ob' parameter support to sip_uri struct and parser. Used by RFC5626 'outbound' support.

Let me know if any issues.
Thanks,
Kennard

Discussion

  • Kennard White
    Kennard White
    2010-08-17

    patch file

     
    Attachments
  • Kennard White
    Kennard White
    2010-08-20

    • summary: base64 and sip_uri ob param support --> base64, sip_uri ob param, msg_cb fix
     
  • Kennard White
    Kennard White
    2010-08-20

    When using this, found two pre-existing bugs that are addressed in 2nd patch file:
    A. tm doesn't zero the sip_msg->msg_cb field when cloning into shm mem. It leaves the pkg mem pointer in place. Later on (in failure route processing) this value is used in different process and get segfault.
    B. the linked-list handling for msg_cb was broken, and wouldn't handle more than 2 callbacks.

    Fix added to this patch upload because it also includes tm cloning the new sip_uri ob param.

     
    • assigned_to: nobody --> bogdan_iancu
     
  • Kennard, I've checked part of this patch to address uninitialized msg_cb pointer. Please check revision 7466 and 7467 and let me know if you still have this issue.

    -Maxim

     
  • Hi Kennard,

    Going through the patches :
    - the msg_cb errors are fixed on SVN - thank you
    - the "ob" URI param - there is no need for it right now, as all URI params are stored into an generic param array
    - regarding the BASE64 function - what is the reason for adding them into core ? I see presence is still using its own function, so basically there is no one using the BASE64 core functions.

    Best regards,
    Bogdan

     
    • priority: 5 --> 2
    • status: open --> open-invalid