#111 warnings and error messages

trunk
closed-accepted
core (47)
5
2009-10-12
2009-10-02
No

Trivial cleanup changes:
- removed warnings when compiling action and modules/ratelimit
- improved error reporting on missing modules
- added some syntax error problem guessing

Discussion

  • patch against trunk-r6208

     
    Attachments
    • assigned_to: nobody --> bogdan_iancu
     
  • what is about this replacement :

    - LM_GEN1(a->elem[0].u.number, a->elem[1].u.string);
    + LM_GEN1(a->elem[0].u.number, "%s", a->elem[1].u.string);

    I would say it is the same ?

    The rest of the patch was applied.

    Thanks and regards,
    Bogdan

     
    • status: open --> open-accepted
     
  • That's for warning elimination / potential bugfix.
    My gcc (4.3.3) warns that format should be a literal string. It seems that:
    log(ERR, "%s%s%s%s%s%s");
    or something similar might explode (it will be used as the format string).

     
    • status: open-accepted --> closed-accepted
     
  • right :)

    Done!