#100 Add Call-Id to failed radius accounting log

1.5.x
closed-accepted
modules (179)
4
2009-08-05
2009-07-29
Alex Massover
No

Hi!

This patch adds Status and Call-Id to failed radius accounting request. The purpose is to be able to track such failed request.

Please see if
rd_vals[r_status-1].n
is a good way to get Status.

The patch is against 1.5.2 (tested on 1.4.3).

Alex Massover & Dror Wald

Discussion

  • Alex Massover
    Alex Massover
    2009-07-29

    This patch adds Status and Call-Id to failed radius accounting request _LOG_.

     
  • Alex Massover
    Alex Massover
    2009-07-30

    Removed patch, doesn't work on 1.5.2 (worked for 1.4.3). Investigating.

     
  • Alex Massover
    Alex Massover
    2009-07-30

    • priority: 5 --> 2
    • assigned_to: nobody --> bogdan_iancu
     
  • Alex Massover
    Alex Massover
    2009-08-02

    Against 1.5.2

     
    Attachments
    • priority: 2 --> 4
     
  • Hi Alex,

    Please check if the patch you uploaded is complete or not - my first feeling (when looking) is that something is some part of it is missing, In the current form it make not much sense.

    Thanks and regards,
    Bogdan

     
  • Alex Massover
    Alex Massover
    2009-08-05

    Hi!

    It's complete, I tested it.

    Currently when radius acc request fails it writes in the log:
    LM_ERR("radius-ing failed\n");
    In production there's no way to track for which call radius-acc failed. The idea of the patch is to have status (start/stop/failed/alive) and the Call-ID in this log, like this:
    LM_ERR("Radius accounting request failed for status: '%s' Call-Id: '%.*s' \n",r_stat->n,req->callid->body.len,req->callid->body.s);

     
    • status: open --> closed-accepted
     
  • Ohh...my mistake...I understood that some extra info is added to the RADIUS request and I was looking for that...
    But now I got it and uploaded the patch on the SVN trunk.

    Thanks and regards,
    Bogdan