#583 Commit #9295 breaks dispatcher

1.8.x
closed-invalid
core (110)
5
2012-12-10
2012-11-14
Dynamic Packet
No

It seems commit #9295 on 1.8 branch breaks AVP in certain cases. Opensips starts fine and some avp related stuff works, but certain scenarios cause this:

Nov 14 11:13:40 ip-10-173-81-249 /usr/sbin/opensips[1042]: ERROR:core:new_avp: invalid AVP name!
Nov 14 11:13:40 ip-10-173-81-249 /usr/sbin/opensips[1042]: ERROR:core:add_avp: Failed to create new avp structure

Script now does not execute as it should and in the end cause failures in call processing. Its possible this also effects trunk (commit #9294) . I have tested by reverting this single commit (#9295) in most resent stable 1.8 and issue is resolved.

Discussion

  • Razvan Crainea
    Razvan Crainea
    2012-11-14

    Hi!

    Can you tell us when do you receive those errors? Is it a certain function that uses AVPs and cannot find them?

    Regards,
    Răzvan

     
  • Dynamic Packet
    Dynamic Packet
    2012-11-14

    Hi Razvan,

    I'm not 100% sure what function and I am unable to test at the moment. But looking at the area of the script it occurs in, it could be ds_select_ds, append_hf, xlog or least likely script comparisons/assignments.

     
  • Dynamic Packet
    Dynamic Packet
    2012-11-14

    This is a bug in dispatcher module. If you fail to set attrs_avp in script, you get errors on ds_select_dst(). Default, per docs, should be null. But ds_select_dst fails in this case after commit #9295. Setting attrs_avp in config, seemingly fixes the issue.

     
  • Dynamic Packet
    Dynamic Packet
    2012-11-14

    • summary: Commit #9295 breaks AVP --> Commit #9295 breaks dispatcher
     
  • I remember fixing this - I will check the backports

     
    • assigned_to: nobody --> bogdan_iancu
     
  • I checked the code (trunk + 1,8) and I see the fix there. Are you sure you are using the latest 1.8 version ? maybe you do not have the fix in your checkout.

    Regards,
    Bogdan

     
    • status: open --> open-invalid
     
  • Dynamic Packet
    Dynamic Packet
    2012-11-26

    I can assure you that SVN checkout of 1.8 as of 2012-11-14 did not solve the problem for me. Was the fix committed after this? Otherwise, perhaps its not working in some case(s) ?

     
  • I'm not able to reproduce this issue - I tried not to define the attrs_avp in mod params, but to populate the attrs in DB. There was not error, neither in ds_select_(), nor in ds_next_dst().

    Are you sure your err logs are related to dispatcher module ? If they are, the dispatcher function should return false to script.

    If you want, you can privately send me some logs ..or may I get access to the server where this happens ?

     
    • status: open-invalid --> closed-invalid
     
  • Finally this was not an problem, but more an improper update from SVN 1.8