Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#418 load_balancer leaks when doing lb_reload

trunk
closed-fixed
modules (454)
5
2011-09-30
2011-09-19
Walter Doekes
No

Hi,

a couple of load_balancer leaks occur when doing lb_reload. Do a while loop around a fifo lb_reload and watch it consume all available mem.

This patch fixes it.

Regards,
Walter Doekes
OSSO B.V.

P.S. Bugs are also in 1.6.

Discussion

    • assigned_to: nobody --> bogdan_iancu
     
  • Walter Doekes
    Walter Doekes
    2011-09-29

    BEWARE:

    I notice that my shm_free(dst); in load_balanced/lb_data.c (add_lb_dsturi) is not quite right.

    Error handling is not what it's supposed to be there, and simply freeing dst is not good enough (as it's still linked in data).

    However, simply removing the added shm_free() isn't good either, as rmap_no can now be higher than actual contents.

     
    • status: open --> open-fixed
     
  • Hi Walter,

    Thanks for you patch - I did a rework of it (see the new attached patched) taking into consideration your warning regarding dst - please double check it.

    Thanks and regards,
    Bogdan

     
  • Walter Doekes
    Walter Doekes
    2011-09-30

    Excellent. That's the one.

    Ship it!

     
    • status: open-fixed --> closed-fixed
     
  • Fix applied on trunk, 1.7 & 1.6