Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#417 leaks in load_balancer (mostly when already OOM)

trunk
closed-rejected
modules (454)
5
2011-09-30
2011-09-19
Walter Doekes
No

Hi,

when investigaging OOM issues, I found a couple of missing pkg_free's in load_balancer.c.

Most of those free's would only be missed if the system was already out of memory, in which case you're screwed anyway, but I do have a couple of points where I'm unsure that the memory gets freed properly at all.

Please take a look at the annotated diff.

Regards,
Walter Doekes

Discussion

  • Walter Doekes
    Walter Doekes
    2011-09-19

    P.S. These issues are in 1.6 as well -- which I'm running.

     
    • assigned_to: nobody --> bogdan_iancu
     
    • status: open --> closed-rejected
     
  • Hi Walter,

    The is no useful addon with this patch - the "leaks" you fixed are all in fixup function - if a fixup function fails, opensips will fail to start, so no worries on leaks :).

    Regards,
    Bogdan