Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#410 SSL connection always corrupts because of sending cleartext

1.7.x
closed-fixed
core (110)
5
2011-09-08
2011-09-06
Anonymous
No

in tcp_main.c around line 790

#ifdef USE_TLS
if (c->type==PROTO_TLS)
n=tls_blocking_write(c, fd, buf, len);
else
#endif
/* n=tcp_blocking_write(c, fd, buf, len); */
start_expire_timer(snd,tcpthreshold);
n=tsend_stream(fd, buf, len, tcp_send_timeout*1000);
get_time_difference(snd,tcpthreshold,tcp_timeout_send);

stop_expire_timer(get,tcpthreshold,0,buf,(int)len,1);

When using TLS, the server will send encrypted data and send non-encrypted data again. This corrupts the SSL connection. I think you guys miss the curly brackets in else.

Discussion

  • Hello,

    Thanks for reporting this. I have committed the suggested fix both in trunk and in the 1.7 branch.

    Regards,
    Vlad

     
    • assigned_to: nobody --> vladut-paiu
     
    • status: open --> closed-fixed