#380 nathelper fix_nated_contact doesn't remove maddr parameter

1.6.x
closed-fixed
modules (454)
5
2011-06-27
2011-06-06
Walter Doekes
No

Hi,

fix_nated_contact doesn't remove the maddr= parameter. I don't think that is wanted behaviour.

INPUT

Contact: <sip:lync.domain.local:5060;transport=Tcp;maddr=172.1.2.3;ms-opaque=8231d2d837d9563b>

EXPECTED

Contact: <sip:1.2.3.4:27257;transport=Tcp;ms-opaque=8231d2d837d9563b>

OBSERVED

Contact: <sip:1.2.3.4:27257;transport=Tcp;maddr=172.1.2.3;ms-opaque=8231d2d837d9563b>

Attached, a patch that fixes expected behaviour.

Regards,
Walter Doekes
OSSO B.V.

(p.s., related to bug 2914149)

Discussion

    • assigned_to: nobody --> bogdan_iancu
     
  • Thanks Walter for the report and the fix - I uploaded it on both trunk and branch, with a small improvement - for locating the maddr param in URI, I used the pre-parsed maddr param from the URI struct :).

    Regards,
    Bogdan

     
    • status: open --> closed-fixed