#324 dialog module calls update_stat(0x0, 1)

1.6.x
closed-accepted
nobody
modules (454)
5
2010-11-25
2010-11-09
Walter Doekes
No

Hi,

if dlg_enable_stats == 0, the stats variables in dialog are not initialized.

However, on error:, update_stat(failed_dlg, 1) is called. This should be if_update_stat. See attached patch.

Regards,
Walter Doekes

P.S. I got to error: because of an apparent memory leak. Or at least an unexplained shortage of memory. But that is a different matter.
Nov 9 12:29:41 sip opensips[8573]: WARNING:core:fm_malloc: Not enough free memory, will atempt defragmenation
Nov 9 12:29:41 sip opensips[8573]: ERROR:core:parse_contacts: no pkg memory left
Nov 9 12:29:41 sip opensips[8573]: ERROR:core:contact_parser: failed to parse contacts
Nov 9 12:29:41 sip opensips[8573]: ERROR:core:parse_contact: failed to parse contact
Nov 9 12:29:41 sip opensips[8573]: ERROR:dialog:get_routing_info: bad Contact HDR
Nov 9 12:29:41 sip opensips[8573]: WARNING:core:fm_malloc: Not enough free memory, will atempt defragmenation
Nov 9 12:29:41 sip opensips[8573]: ERROR:core:insert_new_lump_before: out of pkg memory
Nov 9 12:29:41 sip opensips[8573]: ERROR:rr:insert_rr_param_lump: failed to add before lump
Nov 9 12:29:41 sip opensips[8573]: ERROR:rr:add_rr_param: failed to add 2nd lump
Nov 9 12:29:41 sip opensips[8573]: ERROR:dialog:add_dlg_rr_param: failed to add rr param
Nov 9 12:29:41 sip opensips[8573]: ERROR:dialog:dlg_create_dialog: failed to add RR param
(crash)

Discussion

  • Walter Doekes
    Walter Doekes
    2010-11-09

    1-line patch

     
    Attachments
  • Anca Vamanu
    Anca Vamanu
    2010-11-25

    • status: open --> closed-accepted