#307 Type of db tail

trunk
closed-fixed
core (110)
5
2010-09-21
2010-08-08
No

This is not a serious bug really, but I noticed that `db_con_t.tail` is a long, but in every case I've seen it contains a pointer cast to long instead. Just to ensure portability, it could be a pointer.
It could also explain the field a bit better. Current comment says "Variable length tail, database module specific", which (because of the name) I'd normally expect to be expanding, trailing array (char tail[0]). "Pointer to implementation-specific database state" could be more useful there.

Discussion

  • Changing it from long to pointer does not bring or improve anything. LONG and POINTER are the same as size on all platform.
    So, I see no reason to start changing in all the DB modules if there is no gain ...only if someone comes the done patch for that ;)
    For the comment part, I agree.

    Regards,
    Bogdan

     
    • assigned_to: nobody --> bogdan_iancu
    • status: open --> closed-fixed