#25 acc early_media accounting - 180/183

1.4.x
closed-fixed
modules (454)
5
2008-10-24
2008-10-15
Anonymous
No

In SIP both 180 and 183 can have SDP carry early media.

acc_logic.c: if (code < 200 && ! (early_media && code==183))

should be

acc_logic.c: if (code < 200 && ! (early_media && (code==180 || code==183)))

It shouldn't be a problem since the accounting will still have the code on it. Are there any comments objections? If not let's add this to trunk.

Discussion

  • Hi,

    Probably the condition should more complex, as 180 does not contain SDP all the time (actually not so often) - maybe 180 + has_sdp should do the job.

    Regards,
    Bogdan

     
    • labels: --> modules
    • milestone: --> 1.4.x
    • assigned_to: nobody --> bogdan_iancu
    • status: open --> open-accepted
     
    • status: open-accepted --> closed-fixed
     
  • OK, the final fix was to trigger reply accounting for all provisional replies that have body (via early_media param).

    Thanks and regards,
    Bogdan