#214 Fix registrar when fetching binding for unregistered user

ver 1.5.x
closed-accepted
modules (140)
5
2010-07-30
2010-07-28
Alex Hermann
No

When an UA fetches the bindings for a user and the user isn't registered, properly return an empty contact.

Discussion

  • Alex Hermann
    Alex Hermann
    2010-07-28

    Fix fetching bindings for unregistered users

     
  • Can you use the tracker at sip-router.org?
    http://sip-router.org/tracker/

    SF tracker should not be used anymore for new items.

     
    • status: open --> closed-invalid
     
  • A "Contact" header with no value is *not* valid according to SIP BNF grammar so in case a UA fetches its bindging and there are not bindings then the registrar should reply a 200 without "Contact" header. Taking this into account I suspect that this patch is wrong.

    As a side note, there is a bug/issue open for RFC 3261 related to this
    topic as the RFC 3261 seems to state that the registrar should reply a
    200 with a Contact header containing all the bindings. But it's clear
    (also in the RFC bug report) that the BNF grammar cannot be violated
    so there should be NO Contact header if there are no bindings.

    I close this bug as it not valid. However as Daniel said please use http://sip-router.org/tracker/ for future reports :)

     
  • Alex Hermann
    Alex Hermann
    2010-07-30

    Sorry, the patch is already a bit old and i got the description wrong.

    The patch is actually an addendum to bug 2851214. It makes sure kamailio doesn't return someone else's contact in case there is a failure. The contacts are stored in a global variable and needs to be cleared if it isn't filled with valid contacts.

    Please reopen.

     
  • Reopened as it's clear now the purpose of this patch.

     
    • status: closed-invalid --> open
     
  • Patch committed on git master branch and svn 1.5. Thanks!

     
    • assigned_to: nobody --> miconda
    • status: open --> closed-accepted