#26 do not clobber CFLAGS

closed-out-of-date
None
5
2010-04-15
2008-12-17
Mike Frysinger
No

the configure script clobbers the user CFLAGS which can break builds when the CFLAGS contain critical flags (like ones that control the ABI)

the simple fix is to append CFLAGS in the configure script rather than set it. there is no need to explicitly set CFLAGS to -O2 as autoconf does this by default.

--- openobex-1.3.0/configure.in
+++ openobex-1.3.0/configure.in
@@ -44,10 +44,9 @@ dnl Configure debug facilities
AC_ARG_WITH(debug,[ --with-debug=level Debug level],
debug_level="$withval", debug_level="")

-CFLAGS="-O2"
if test "$debug_level" != ""; then
AC_DEFINE_UNQUOTED([OBEX_DEBUG],$debug_level, [debug level])
- CFLAGS="-g -O1"
+ CFLAGS="$CFLAGS -g -O1"
fi

AC_ARG_WITH(dump,[ --with-dump=level Dump level],

Discussion

    • assigned_to: nobody --> infotux
     
  • already fixed

     
    • status: open --> closed-out-of-date