Re: [openobex-users] [PATCH] OpenObex on Visual Studio 2005

[Hendrik S. <po...@he...>]

Am Sonntag 24 Juni 2007 06:46 schrieb Denis Kenzior:
> I wanted to see how easily OpenOBEX compiles on Visual Studio 2005.
> Overall it wasn't too bad, but required a bit of effort.  Attached is a
> patch to make it compile.  I've tested successfully with TCP transport.
>
> Some notes:
>
> Library:
> - Visual C++ compilers don't and probably never will support C99
> semantics.  Thus C99 struct initialization & variable declaration must be
> done the old way.

Could be but that really sucks :-(
You cannot just assign in6addr_loopback, you have to memcpy() it.

> - Win32 understands send and recv for sockets, not read and write

Should be already solved by the win32 patchset. From other patch lines, I 
clearly see that you did not use it.

> - Win32 doesn't have stdint.h, had to fake it, see attached obex_stdint.h

For normal cases, uses inttypes.h instead. One of both is present everywhere 
but stdint.h always includes inttypes.h and the latter actually defines what 
we want.
Doesn't VC++ have inttypes.h?

> - Win32 doesn't have inet_ntop, had to fake it

Is that worth the effort for a _Debug_ message? Isn't there a WSA function 
that comes close to it and could be used?

> - Fixed a bug where obex client resets its mode to server before
> delivering an event (this broke obex_test)

Seperate patch, then, as it's not related to the other stuff.

> - Win32 doesn't support symlinks, had to manually copy headers to
> include/openobex.  This needs a better solution.  Can we move includes to
> include/openobex in the source tree?

Yes, see win32 patchset. I already suggested that, too.

A vcproj file could be generated  by meta compilers, e.g. CMake. The latter 
doesn't support cross-compiling, yet, though.

HS