#12 Fix Processing of Data In SD Tool

closed-fixed
None
2
2010-07-09
2010-07-08
James Kosin
No

This patch fixes the processing of the input stream. If the user finishes the file and forgets to terminate with a blank line, the previous version would ouput nothing or just all the other paragraphs except the last.
This catches any left over input and processes it at the end of the file.
Also, adds a small comment... para is actaully a variable that could be holding a paragraph (multiple sentences) of data. Which the sentence detector should be very accustomed to dealing with as input.

James

Discussion

  • James Kosin
    James Kosin
    2010-07-08

    SentenceDetectorTool.java Patch 1/1

     
  • James Kosin
    James Kosin
    2010-07-08

    • priority: 5 --> 2
     
  • Joern Kottmann
    Joern Kottmann
    2010-07-08

    Thanks for the patch and bug report James. I applied the patch and afterwards re-factored the while loop. Please review my changes.

    Maybe you can just close this issue, to indicate that your problem is solved.

     
  • Joern Kottmann
    Joern Kottmann
    2010-07-08

    • status: open --> open-accepted
     
  • James Kosin
    James Kosin
    2010-07-09

    • assigned_to: nobody --> joernkottmann
    • status: open-accepted --> open-fixed
     
  • James Kosin
    James Kosin
    2010-07-09

    Thanks, your refactored is working.

     
  • Joern Kottmann
    Joern Kottmann
    2010-07-09

    • status: open-fixed --> closed-fixed