Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#482 wxCatapult build system: --version and About should automatically show git commit id or output of "git describe", if a current commit is not tagged with not RELEASE_* tag

closed-wont-fix
joxy
wxCatapult (26)
3
2014-02-22
2013-07-30
joxy
No

Currently, they emit the release string only, for git versions.

Discussion

  • joxy
    joxy
    2013-07-30

    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -0,0 +1 @@
    +Currently, they emit the release string only, for git versions.
    
     
  • That's because 'release flag' is on 'true'. Then only the release name is given. If you set it to 'false' (both in version.py and version.mk) it will also include the revision number in the user visible version info. That's on purpose. Please close this bug if you can confirm that this is what you meant.

     
  • joxy
    joxy
    2013-08-02

    • summary: wxCat.: --version and About should show git commit id or output of "git describe", if not RELEASE_ tag --> wxCatapult build system: --version and About should automatically show git commit id or output of "git describe", if a current commit is not tagged with not RELEASE_ tag
     
  • joxy
    joxy
    2013-08-02

    Manuel: we need more discussion.

     
  • Usually, we keep the release flags on "False" during development. So, all development builds show the revision. When we actually release, we set the flag on "True", so that the version is completely clean, it just shows the actually released version. That's fine.

    But since we stopped developing wxCatapult, we left the release flags on "True". Now that people are working again on this code, we should probably change the flags to "False" again, until we actually release the code again.

     
  • So, feel free to put them on "True" and then I propose to close this bug. (It's not a bug, it's intended behaviour.)

     
  • joxy
    joxy
    2013-08-07

    Maybe I'll study Python a bit and implement this, so that the flag will be auto-detected from git tags... So let it stay for now

     
    • status: open --> closed-wont-fix
    • Priority: 9 --> 3
     
  • I don't think we're going to change this (for now).