#40 Patch to make osx compile in MSVC

closed-fixed
None
5
2004-08-26
2004-06-10
Tony Dodd
No

The patch replaces dynamic array bounding with new
statements, makes allowance for \ as well as / as path
separator and adds emulators for two simple Unix
system routines. Note that the new code is only really
tested when the -x no-expand-external option is
specified. I have deleted any memory I allocated but
clearly there are still memory leaks in this code.

Discussion

  • Tony Dodd
    Tony Dodd
    2004-06-10

    Diff file for osx projects

     
  • Logged In: YES
    user_id=188003

    Hi Tony. My patch rejects your patch, so I could not apply it
    yet. Looking at the source of the patch, it seems that there
    are indeed some errors, for example, the patch suggests a
    modification to

    > #ifdef SP_MSDOS_FILENAMES
    > char *ppp = strrchr(path,'\\');
    > if (ppp && (ppp > pp || pp==NULL)) pp=ppp; #endif

    which would not compile as the #endif needs to be at the
    start of the line. Could you look at this and tell whether this is
    an error on your side and if so, resubmit the patch? Ideally
    from diff -u as context diffs are more difficult to handle. Or
    just attach / send me per mail the modified files.

     
    • assigned_to: nobody --> hoehrmann
     
  • Tony Dodd
    Tony Dodd
    2004-06-11

    Logged In: YES
    user_id=1036552

    The problem is the usual one with line breaks under Windows.
    I'll correct and also diff with the -u option later today.

     
  • Tony Dodd
    Tony Dodd
    2004-06-13

    Logged In: YES
    user_id=1036552

    I've attached a new patch made with the -u option as
    requested. It is supposed to have lines terminated with line
    feed characters only, and so will look peculiar in DOS but
    should be OK in Unix.

     
  • Tony Dodd
    Tony Dodd
    2004-06-13

     
  • Logged In: YES
    user_id=188003

    Ok, there was only a minor error in the second patch, I've
    applied it to my local copy and it indeed seems that osx
    compiles now, I'll look a bit closer at the code later today and
    then commit it to CVS and announce it to the list. Thanks so
    far.

     
    • status: open --> closed-fixed
     
  • Logged In: YES
    user_id=188003

    I've applied the patch with one slight modification.