From: Audet, Jean-M. <Jea...@ca...> - 2004-02-26 21:08:30
|
Hi, Here is some issue for the function saHpiRptEntryGet: 1) -File: safhpi.c -Fct: saHpiRptInfoGet -Test Type: Usage with bad parameters -Descriptions: Session is not checked. -Results: An invalid session call will go throught.. without returning errors. -Proposed: Add the following: struct oh_session *s; /* Add on top of the function */ s = session_get(SessionId); if (!s) { dbg("Invalid session"); data_access_unlock(); return SA_ERR_HPI_INVALID_SESSION; } *** WARNING.. not sure if the data_access_lock() call must be made before calling session_get.. -Tested: Yes Jean-Michel Audet Kontron Canada Inc. |