#686 Assign more telling names to new IPMI-2.0 entities

3.2.0
closed-fixed
Anton Pak
None
5
2012-07-13
2012-06-04
Anton Pak
No

We've encountered the following issue:

- Last IPMI-1.5 defined entity is BATTERY (0x28)

- IPMI-2.0 introduced 12 more entities: 0x29 - 0x34:
-- 28h Battery - last IPMI-1.5 defined entity
-- 29h Processing blade
-- 2Ah Connectivity switch
-- 2Bh Processor/memory module
-- 2Ch I/O module
-- 2Dh Processor/ IO module
-- 2Eh Management Controller Firmware
-- 2Fh IPMI Channel
-- 30h PCI Bus
-- 31h PCI Express Bus
-- 32h SCSI Bus (parallel)
-- 33h SATA / SAS bus
-- 34h Processor / front-side bus

- SaHpi.h recognizes those entities but for 0x29 - 0x2D the names are not pretty:

SAHPI_ENT_BATTERY,
SAHPI_ENT_RESERVED_1,
SAHPI_ENT_RESERVED_2,
SAHPI_ENT_RESERVED_3,
SAHPI_ENT_RESERVED_4,
SAHPI_ENT_RESERVED_5,
SAHPI_ENT_MC_FIRMWARE,
SAHPI_ENT_IPMI_CHANNEL,
SAHPI_ENT_PCI_BUS,
SAHPI_ENT_PCI_EXPRESS_BUS,
SAHPI_ENT_SCSI_BUS,
SAHPI_ENT_SATA_BUS,
SAHPI_ENT_PROC_FSB,
SAHPI_ENT_CLOCK,
SAHPI_ENT_SYSTEM_FIRMWARE,

Suggest to change RESERVED_1-5 to more telling names.

Discussion

  • Anton Pak
    Anton Pak
    2012-06-04

    Implemented in trunk (rev. #7449)

     
  • Anton Pak
    Anton Pak
    2012-06-04

    • status: open --> closed-fixed
     
  • Anton Pak
    Anton Pak
    2012-07-13

    • milestone: 2691519 --> 3.2.0