Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#1670 Polling SEL fails when reservation lost

Future
open
5
2011-10-12
2011-10-11
David McKinley
No

When polling the SEL, a check is made to see if the SEL Info data has changed. If not, no reading of the SEL is done. If it has changed, the SEL is read to capture the new events. Then, if during reading the SEL the reservation is lost, it goes back and reads the SEL Info again. At this point, it no longer sees a change - because it compares with the data just read. As a result, the new events on the SEL are not read and processed until the SEL Info record changes yet again (i.e., when the next event is generated).

In addition, the function that reads the SEL is very inefficient by re-reading the entire SEL every time it changes, instead of trying to read just the new entries.

I have prototyped changes that fix this problem, and avoids re-reading the entire SEL on each update, which can be committed after the 3.0 release is out.

Discussion

  • Anton Pak
    Anton Pak
    2011-10-11

    If I recall right the implementation clears SEL after reading.
    It makes the things little bit more efficient.

     
  • David McKinley
    David McKinley
    2011-10-11

    Maybe it is supposed to do that, but it doesn't when I run it. In general, clearing the SEL after every event would not be a good idea, anyway; there may be other users of the IPMI data that would not want the SEL regularly cleared. It could also cause problems with wear-out of the flash memory.

     
  • David McKinley
    David McKinley
    2011-10-12

    • milestone: 2040045 --> Future
    • assigned_to: larswetzel --> davidmckinley