#245 OPAL - mpeg4 - cleanups and more docs

closed-accepted
nobody
OPAL (138)
5
2007-06-16
2007-06-11
Michael Smith
No

Cleanups, stability fixes, and documentation for the codec parameters.

- document recommended encoder and decoder settings for various bitrates
- allow for older ffmpeg version
- fixes for stack alignment problems which were causing crashes with MMX enabled in FFmpeg
- sweep "marker does not match f_code" errors under the rug to save CPU
- whitespace fixes: try to keep formatting consistent at least within the same function :)
- ensure pointers are set to NULL on free to make bugs appear faster
- use "frame time" instead of fps, to match other video codecs
- don't open encoder until first frame is encoded - avoids needless reopens after initial config changes
- always encode from _rawFrameBuffer since we know it has FF_INPUT_BUFFER_PADDING_SIZE at the end
- remove some cerr's / cout's
- display I-frame even if it had errors so we aren't hosed for the rest of the GOP

Discussion

  • Michael Smith
    Michael Smith
    2007-06-11

    diff -u from opal/plugins/video/MPEG4-ffmpeg

     
    Attachments
  • Damien Sandras
    Damien Sandras
    2007-06-16

    Logged In: YES
    user_id=63500
    Originator: NO

    I applied your patch to the CVS, thanks !

     
  • Damien Sandras
    Damien Sandras
    2007-06-16

    • status: open --> open-accepted
     
  • Damien Sandras
    Damien Sandras
    2007-06-16

    • status: open-accepted --> closed-accepted