Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo
I have checked in my changes for the following requirement:
The code can be found at:
Some of the languages in list of ISO 639-2 has multiple ISO 639-2 codes while only having a single 639-1 code. The list_options table has primary key on the language itself, so the current structure of the table cannot support both 639-2 codes. (ie: Albania, Welsh etc). For now, I have included only the first 639-2 code in the sql script.
Please review and let me know of any necessary changes.
Need to use this URL to avoid diff that are just trailing spaces...
Here's the link to relevant MU2 item for this code:
Placed a code review on github. Looking forward to the next revision.
Revisions checked in:
I rebased all your work into one commit on this branch (the commit at the top):
That will make it easier for developers to review it :)
Use this URL: https://github.com/bradymiller/openemr/commit/c5c9f8138d36eb372f1f4a8080565782d3bdce27?w=1
with the ?w=1 at the end it will ignore spaces that are meaningless.
I just placed a review on github:
(Do not use Tony's link above since that will not show my inline comments)
To see my inline comments, search for bradymiller on the page.
Looking forward to the next revision.
For next revision, work from my branch by pulling it into your repo with following commands:
git remote add brady https://github.com/bradymiller/openemr.git
git fetch brady
git checkout brady/jajalla23-demographics_2
(ignore the warning stuff)
git checkout -b demographics_3
And you now have your local branch demographics_3 to work from :)
Changes checked in
branch name: demographics_3
Will be much better if you rebase the two commits in your branch into one commit:
Let me know if you need instructions on how to do this (I rec. doing this in another branch, such as demographics_4).
For those whom are just testing code, note this code can be tested in the following UP FOR GRABS demo:
Brady, are you referring to demographics and demographics_3 commit?
i do need guidance how to rebase both commits. i seem to struggle when i have to merge
Recommend combining the two commits in demographics_3 into one commit to make it easier to review. Generally is a good idea to do this in a new separate branch.
(go to branch)
git checkout demographics_3
(now create a new branch)
git checkout -b demographics_4
(now do the interactive rebase (note the number after HEAD is how many commits to bring in))
git rebase -i HEAD~2
(Now you'll be in a text editor which lists two commits:)
in the second line, change the "pick" to "squash"
(Now you'll be in a text editor which shows commit comments:)
uncomment the two current lines there (ie. remove them) and place "demographics changes to support MU2, take 3"
Now you can push this branch which contains one combined commit to github.
Also as an aside,
When learning git, best to avoid merging. It's something that will be much more clear after gain mastery of rebase and cherry-pick. A nice command to see how a branch looks(especially when you start using merge), is the following:
git log --graph --pretty=format:'%Cred%h%Creset -%C(yellow)%d%Creset %s %Cgreen(%cr) %C(bold blue)<%an>%Creset' --abbrev-commit --date=relative
To make it easier to do the above command (and others) I place the following alias section in my .git/config file in my local repository:
st = status
ci = commit
br = branch
co = checkout
df = diff
lg = log -p
lf = log --graph --pretty=format:'%Cred%h%Creset -%C(yellow)%d%Creset %s %Cgreen(%cr) %C(bold blue)<%an>%Creset' --abbrev-commit --date=relative
Thus, just lf will work for the command (note I also shorten some other used commands).
Let me know if this is any better:
Just tested the above mentioned Demo.
Is there a reason why Language STATS are not in Alphabetical order? Rather hard to find a language in the unsorted long list.
YES, I saw Dutch Flemish, but I missed Dutch, Nederlands, which I added but it does not show after Dutch Flemish, but only at the end.
Could be solved by disabling the sort order in the List, but I did not want to make changes in this testing Phase.
ISO 639-2 : dut(B)|nld(T)
What is the explanation of the ISO 639-2 in relation to (B) (T)?
ISO 639-2 is the alpha-3 code in Codes for the representation of names of languages. With reference from the link, there are 21 languages that are assigned with alternative ISO 639-2 codes for bibliographic or terminology purposes. In such cases, the languages are designated as "B" for bibliographic and "T" for terminology.
OpenEMR Customization/Support provider,
Tnx for the answer. I was looking through the tables and only concentrating on Dutch.....
I should have read: Dutch, Flemish two separate languages counted as one in the ISO 639-2 coding. (one row per language code)
BTW it is easy to change the sort order in the Administration => List => Language table. Also easy to get the most spoken language choices at the top. I have to remember to delete the Dutch; Nederlands language from the Demo (done) and made my own preferred sort order......
For the US is the Code for Etnicity: Hispanic/Non hispanic sufficient for Demographics?
In the CDC site I found a more extensive list.
Also a list for Race at CDC. (Europeans and Asians might dispute the one row for their race, but this is for Demographics MU-2; USA regulations compliance)
Or is there another list from some International Coding organisation that can include European, Asian, African races without compromising the MU-2 requirements?
For MU2 requirement, Hispanic/Non hispanic along with declined to specify option will be sufficient for Ethnicity in Demographics. Also the list of races can be extended as needed without compromising MU2.
Abganistan, Tibetan and Chinese (may be more) are still in need of alphabetical order.
I wonder if anybody still speaks medieval Dutch ;-))
The Decline option seems to be a nice extra, for compliance with the MU2.
Sorry here I confused Ethnicity and Race....
V4.1.2 Looking in Demo version:
It might be good to bring Interpreter field up towards just under Language, for cosmetics.
Could also be a if then field. If only medieval Dutch is spoken the interpreter will be:any name and tel or e-mail the actual field length is now 20 char. (.... my grand fathers, grandfather.. ;-)) ....)
Also the languages you include from the old version like Deaf etc, have probably to put in the correct place for sort order.
Placed a review on github:
Look forward to next revision.
i have completed the code changes (without upgrade script and database script) based on the review for demographics