Menu

#264 gprelations by name

open
nobody
None
5
2015-06-25
2015-06-16
MD Support
No

This commit adds function setGpRelByName to make calls more readable. Mapping array includes multiple common names for same table.

setGpRelByName("documents", $newid, "pnotes", $noteid);

Current setGpRelation calls are not affected.

Also added a placeholder for procedure_orders since a single encounter can (and in many cases does have) multiple orders. Relation (1->9) provides accurate capture of order specific information.

Discussion

  • MD Support

    MD Support - 2015-06-16

    Rev 1 based on comments.

     
  • Rod Roark

    Rod Roark - 2015-06-23

    Added some comments to Rev 1.

     
  • MD Support

    MD Support - 2015-06-25

    Rev 2 & Rev 3 incorporate changes based on comments.

    Sorry. Need to figure steps for squashing the 4 commits.

     
  • Rod Roark

    Rod Roark - 2015-06-25

    Note also my comment on Rev 1 line 36. Pretty sure that's a bug.

    To squash the last 4 commits to 1, do this:

    git rebase -i HEAD~4

    You'll need to edit the metadata as indicated. Also that will keep you from pushing the same branch again to github, so you'll need to either delete the current one there or make a new one.

     
  • MD Support

    MD Support - 2015-06-25

    The developer had changed line 36 after Rev 1. So Rev 2 commit fixed line 36 from

    return array_key_exists($strTab, $mapNames);

    to

    return (array_key_exists($strTab, $mapNames) ? $mapNames[$strTab] : false);

     

Log in to post a comment.