Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#182 AlwaysAddARHeader doesn't always add AR Header

2.8.4
closed-fixed
None
5
2013-12-09
2013-12-05
John Wood
No

Description:

Despite configuring AlwaysAddARHeader to true/1, when a From header is missing OpenDKIM logs "can't determine message sender; accepting" and no header is added. In this situation it should still add and AR header (appropriately failing it). It's impossible to use the AR header for filter/decision making if the behaviour isn't consistent.

Steps to Reproduce:

Push a message through verify missing a From header

Requested behaviour modifications:

Add an AR header, always, even if there are RFC violations. Certainly violations / missing requirements will result in AR failing, but that is what we want to see.

Discussion

    • status: open --> pending
     
  • I'm not sure about this. A-R is supposed to relay an authentication result. For a completely malformed message, DKIM has no result to report.

    What's an example of an A-R field you'd expect to see in this case?

     
    Last edit: Murray S. Kucherawy 2013-12-05
  • "permerror" might be a reasonable choice here.

     
  • John Wood
    John Wood
    2013-12-05

    I think permerror is appropriate here.

     
    • status: pending --> open
     
  • Fix will be available in 2.9.0.Beta2.

     
  • John Wood
    John Wood
    2013-12-05

    Fantastic. Thank you.

     
  • v2.9.0 released.

     
    • status: open --> closed-fixed