Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#142 opendkim-testmsg.c should use opendkim.conf for TMP

2.6.7
closed-fixed
opendkim (95)
6
2012-10-24
2012-09-18
Glen
No

opendkim-testmsg.c is improperly hard-coding the path to the TMP directory where it will place working files. It should be following the TemporaryDirectory value in opendkim.conf, when present.

AS-IS:

#define TMPTEMPLATE "/var/tmp/dkimXXXXXX"

Discussion

  • Moving to Bugs.

     
    • labels: 1195570 --> opendkim
    • milestone: --> 2.6.7
     
  • I'll change all of the default temporary directories to /tmp in the next release.

    I don't think opendkim-testmsg needs to read opendkim.conf. Doing this as either an environment variable or a command line option makes sense.

    There's also an unlink() call missing which is why the temporary files are leaking. I'll fix that as well.

     
    • priority: 5 --> 6
    • assigned_to: nobody --> cm-msk
     
    • status: open --> closed-fixed
     
  • Fix for this bug included in new release.