#68 "File removed" warning doesn't show filename

1.6
open-accepted
Holger Brandl
None
5
2009-09-03
2009-01-31
No

Minor issue, found while troubleshooting my installation:

The warning-dialog "File not found, thus removed from all categories" doesn't show what file was not found/missing.
See attached screenshot.

Discussion

  • warning dialog that should state the filename

     
    Attachments
  • Turns out, that this is a translation error - the variable that should be replaced by the code was removed from the translation.

    for example in german properties:
    CategoryUtils.fileNotFound=wurde nicht gefunden und wird deshalb von allen Kategorien entfernt.

    and the code uses
    String msg = Utils.getRB().getString("CategoryUtils.fileNotFound").replaceAll("<<filename>>", "'" + cardFile.getFileLocation().getAbsolutePath() + "' ");

    thus the string should be
    CategoryUtils.fileNotFound=<<filename>> wurde nicht gefunden und wird deshalb aus allen Kategorien entfernt.

    also (IMHO) "aus" allen Kategorien sounds better than "von" allen Kategorien

    $ grep CategoryUtils.fileNotFound= resources/* |grep -v "<<filename>>" |awk -F : '{ print $1 }'
    resources/translation_de.properties
    resources/translation_es.properties
    resources/translation_fr.properties

     
  • Holger Brandl
    Holger Brandl
    2009-09-03

    • milestone: 796266 --> 1.6
    • status: open --> open-accepted
     
  • Holger Brandl
    Holger Brandl
    2009-09-03

    • assigned_to: nobody --> holgerbrandl