Re: [Openbts-discuss] [PATCH] Fix smqueue crashes for unavailable subscribers

[Ivan K. <Iva...@fa...>]

I confirm, these patches were created by Alexander.  :)

2012/12/22 Alexander Chemeris <ale...@gm...>

> It was me who created the patches - I just forgot it was at the
> computer configured by Ivan. Patches with the fixed ownership are
> attached.
>
> On Sat, Dec 22, 2012 at 7:52 AM, Kurtis Heimerl
> <khe...@cs...> wrote:
> > These patches are from Ivan, can we get him to say he hold no copyright
> on
> > them just to be certain? It might be best to do that in the commit
> messages,
> > in the future too.
> >
> >
> > On Wednesday, December 19, 2012, Alexander Chemeris wrote:
> >>
> >> Fixed one more issue with the patch. Works as expected now.
> >>
> >> On Thu, Dec 20, 2012 at 1:25 AM, Alexander Chemeris
> >> <ale...@gm...> wrote:
> >> > Sorry, had a typo at the last patch. Here is a fixed version.
> >> >
> >> > On Wed, Dec 19, 2012 at 10:26 PM, Alexander Chemeris
> >> > <ale...@gm...> wrote:
> >> >> This set of patches fixes smqueue behavior when a message can't be
> >> >> delivered to a subscriber, when he is registered, but not available.
> >> >>
> >> >> In this case we create "bounce" message which included text from the
> >> >> original message. To do this we have to extract the text from the
> >> >> original DELIVER message we were trying to deliver. Previously
> >> >> get_text() function blindly assumed we have SUBMIT message which led
> >> >> to crashed and other weird behavior. With this patches it understands
> >> >> both SUBMIT and DELIVER messages and sanely ignores everything else.
> >> >> This is done in patch 0003.
> >> >>
> >> >> I also slightly improved robustness of the code in the patch 0004,
> >> >> added comments in 0001 and improved logging in 0002.
> >> >>
> >> >> Note, that part of 0003 - should be applied to OpenBTS repo as well.
> >> >>
> >> >> Changes are not trivial, but I don't care and don't claim any
> copyright
> >> >> on them.
> >> >>
> >> >> --
> >> >> Regards,
> >> >> Alexander Chemeris.
> >> >> CEO, Fairwaves LLC / ООО УмРадио
> >> >> http://fairwaves.ru
> >> >
> >> >
> >> >
> >> > --
> >> > Regards,
> >> > Alexander Chemeris.
> >> > CEO, Fairwaves LLC / ООО УмРадио
> >> > http://fairwaves.ru
> >>
> >>
> >>
> >> --
> >> Regards,
> >> Alexander Chemeris.
> >> CEO, Fairwaves LLC / ООО УмРадио
> >> http://fairwaves.ru
>
>
>
> --
> Regards,
> Alexander Chemeris.
> CEO, Fairwaves LLC / ООО УмРадио
> http://fairwaves.ru
>
>
> ------------------------------------------------------------------------------
> LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
> Remotely access PCs and mobile devices and provide instant support
> Improve your efficiency, and focus on delivering more value-add services
> Discover what IT Professionals Know. Rescue delivers
> http://p.sf.net/sfu/logmein_12329d2d
> _______________________________________________
> Openbts-discuss mailing list
> Ope...@li...
> https://lists.sourceforge.net/lists/listinfo/openbts-discuss
>
>


-- 
Regards,
Ivan Kluchnikov.
http://fairwaves.ru