#85 report writer test failure during make check

reportwriter
closed
Simon Sobisch
3
2015-01-04
2014-07-13
No

Compiling and then running make check against Branches/reportwriter rev318 (no changes since) 11 tests fail:

93: Check REPORT error/warning FAILED (syn_reportwriter.at:118)
94: REPORT not positive integers in COL / LINE PLUS FAILED (syn_reportwriter.at:175)

423: PAGE LIMIT REPORT FAILED (run_reportwriter.at:374)
424: PAGE LIMIT REPORT 2 ok
425: Customer Report FAILED (run_reportwriter.at:640)
426: Charge Report FAILED (run_reportwriter.at:1004)
427: Charge Report 2 FAILED (run_reportwriter.at:1385)
428: Charge Report 3 FAILED (run_reportwriter.at:1761)
429: Charge Report 4 FAILED (run_reportwriter.at:2123)
430: Payroll Report FAILED (run_reportwriter.at:2843)
431: STUDENT REPORT FAILED (run_reportwriter.at:3075)
432: ORDER REPORT FAILED (run_reportwriter.at:3361)

Related

Discussion: which gnu-cobol version for which purpose?

Discussion

  • Brian Tiffin
    Brian Tiffin
    2014-07-22

    • status: open --> accepted
    • assigned_to: Brian Tiffin
    • Priority: 1 --> 2
     
  • Brian Tiffin
    Brian Tiffin
    2014-07-22

    These are not failures of the engine, but the line numbers (of expected compiler output) captured for comparison in the testsuite are off by one. Will fix.

     
  • Brian Tiffin
    Brian Tiffin
    2014-07-22

    • status: accepted --> pending
     
  • Brian Tiffin
    Brian Tiffin
    2014-07-22

    Checked in rev #343 [r343]

    One program id was wrong, needed to add some quadrigraphs for trailing spaces, and the line number corrections

     

    Related

    Commit: [r343]


    Last edit: Brian Tiffin 2014-07-22
  • make test fails as it does not build the RW tests and therefore the compare fails.

     
  • Brian Tiffin
    Brian Tiffin
    2014-07-28

    • status: pending -> closed
     
    Last edit: Vincent (Bryan) Coen 2014-07-30
    • On rev 345 make test still fails with RW NOT being extracted or run see:


      Total executed programs : 418 - Total performed tests : 9710

      Comparing total test results
      diff ./summary.txt summary.log
      14d13
      < RW 6 6 0 0 42 0 0 0 42
      17c16
      < Total 424 424 0 0 9589 0 20 143 9752


      Total 418 418 0 0 9547 0 20 143 9710
      Makefile:437: recipe for target 'test' failed
      make: *** [test] Error 1


      and showing summary.txt :


      [vince@study cobol85]$ cat summary.txt
      ------ Directory Information ------- --- Total Tests Information ---
      Module Programs Executed Error Crash Pass Fail Deleted Inspect Total
      ------ -------- -------- ----- ----- ----- ---- ------- ------- -----
      NC 95 95 0 0 4371 0 4 26 4401
      SM 17 17 0 0 293 0 2 1 296
      IC 25 25 0 0 247 0 4 0 251
      SQ 85 85 0 0 521 0 0 89 610
      RL 35 35 0 0 1830 0 5 0 1835
      IX 42 42 0 0 510 0 1 0 511
      ST 40 40 0 0 289 0 0 0 289
      SG 13 13 0 0 313 0 0 0 313
      OB 7 7 0 0 34 0 0 0 34
      IF 45 45 0 0 735 0 0 0 735
      RW 6 6 0 0 42 0 0 0 42
      DB 14 14 0 0 404 0 4 27 435
      ------ -------- -------- ----- ----- ----- ---- ------- ------- -----
      Total 424 424 0 0 9589 0 20 143 9752
      --------------------------

      And summary.log:


      ------ Directory Information ------- --- Total Tests Information ---
      Module Programs Executed Error Crash Pass Fail Deleted Inspect Total
      ------ -------- -------- ----- ----- ----- ---- ------- ------- -----
      NC 95 95 0 0 4371 0 4 26 4401
      SM 17 17 0 0 293 0 2 1 296
      IC 25 25 0 0 247 0 4 0 251
      SQ 85 85 0 0 521 0 0 89 610
      RL 35 35 0 0 1830 0 5 0 1835
      IX 42 42 0 0 510 0 1 0 511
      ST 40 40 0 0 289 0 0 0 289
      SG 13 13 0 0 313 0 0 0 313
      OB 7 7 0 0 34 0 0 0 34
      IF 45 45 0 0 735 0 0 0 735
      DB 14 14 0 0 404 0 4 27 435
      ------ -------- -------- ----- ----- ----- ---- ------- ------- -----
      Total 418 418 0 0 9547 0 20 143 9710
      --------------------------

      Vincent

       
      Last edit: Simon Sobisch 2014-11-24
  • Please re-Open as not fixed see above report.

    Would have done it myself but cannot find a way to do so.

     
    • Brian Tiffin
      Brian Tiffin
      2014-07-30

      Back to open. The test cases are fairly fragile in terms of dependence on messages and line numbers. Will look into recoding how the expectations are handled. All these test are actually succeeding, but failing the compare on trivial deltas in compiler messaging.

      Thanks Vincent.

       
  • Brian Tiffin
    Brian Tiffin
    2014-07-30

    • status: closed --> open
     
  • Can run cobol85 tests by modding tests/cobol85/Makefile.in

    @COB_MAKE_IX_FALSE@MODULES = NC SM IC SQ RL ST SG OB IF RW DBNOIX
    @COB_MAKE_IX_TRUE@MODULES = NC SM IC SQ RL IX ST SG OB IF RW DB
    

    (Adding RW after IF)

    and more importantly to tests/cobol85/Makefile

    #MODULES = NC SM IC SQ RL ST SG OB IF RW DBNOIX
    MODULES = NC SM IC SQ RL IX ST SG OB IF RW DB
    

    [Again adding RW after IF)

     
    Last edit: Simon Sobisch 2014-11-24
    • Group: unclassified --> GC 2.0
     
  • Simon Sobisch
    Simon Sobisch
    2014-11-24

    • summary: V2.1 report writer test failure during make check --> report writer test failure during make check
    • Group: GC 2.0 --> reportwriter
     
  • Simon Sobisch
    Simon Sobisch
    2014-11-24

    • status: open --> pending
    • assigned_to: Brian Tiffin --> Simon Sobisch
    • Priority: 2 --> 3
     
  • Fault fixed by r484 & 485

     
    • status: pending --> closed