#201 Return video device information from the converter

Unstable_(example)
closed-fixed
nobody
PTLib (107)
5
2012-05-28
2012-05-25
Anonymous
No

Some function of the PVideoDevice do not return the destination information if a converter exists. this may cause some problems, if we request the information of the converted image but getting the data of the underlying device, which must not necessarily have the same information. If we want to have the information of the underlying device, we have to use PFrameInfo::GetXXX(). Now, the PFrameInfo::GetFrameWidth/Height does NOT call GetFrameSize which might be overloaded in subclasses of PFrameInfo.

Found by Karl Schwerdt, patch created by me :)

Discussion

  • I do not understand the changes to PFrameInfo::GetFrameWidth/Height, as far as I can tell they do precisely nothing.

    The change to PVideoDevice::GetColourFormat() does seem reasonable and I have included it.

    It also noticed some other anomalies in that area, for example the code you provided, and the existing code, bit assume a grabber and would not have worked on a video output device. I have tried to fix this as well.

     
    • status: open --> closed-fixed