Re: [Opalvoip-devel] H264 codec failed for latest Luyten svn

[Alexander S. <ale...@gm...>]

  As a temporal solution for previously mentioned problem I changed default
value for "Max Tx Packet Size" option to 1400.

It's helps a lot with buffer overrun inside H264 codec. I hope it is a right
way to deal with this problem.

Small patch for opal/src/opal/mediafmt.cxx 

 

1682c1682

<   AddOption(new
OpalMediaOptionUnsigned(OpalMediaFormat::MaxTxPacketSizeOption(),
false, OpalMediaOption::NoMerge,     1400,                        100,
8192));

---

>   AddOption(new
OpalMediaOptionUnsigned(OpalMediaFormat::MaxTxPacketSizeOption(),
false, OpalMediaOption::NoMerge,     8192,                        100,
8192));

 

 

Also there is probably something must be done to address the possible buffer
overrun in the first place. As I understand msg handler function receiving
maximum size of destination buffer.

So it is possible to check size of incoming data before start to receive
them. I will look for correct way to produce error in this case.