Re: [Opalvoip-devel] [Opalvoip-user] OPAL v3.6.1 -> v3.6.2 API change
Brought to you by:
csoutheren,
rjongbloed
From: Robert J. <ro...@vo...> - 2009-05-28 01:05:15
|
The patch to h323neg.* is incorrect, the H323Connection::OnModeChanged() function is for completing an INCOMING mode change request from the remote. For an OUTGOING mode change, the H323Connection::OnAcceptModeChange() call back is executed on the receipt of the ACK. Those functions were removed because I am quite certain it does not work properly, at least as far as opening correct OpalMediaStreams in concerned. I had the option of trying to fix it, or removing it, as non-working functions is probably the worst choice. Though, it might work for t38modem due to whatever other function overrides you may have, so I have restored the H323Connection::RequestModeChangeT38() and corresponding implementation in H323Connection::OnAcceptModeChange() to the exactly way it was, and has been for years. Except for adding a "deprecated" warning. Robert Jongbloed OPAL/OpenH323/PTLib Architect and Co-founder. > -----Original Message----- > From: Vyacheslav Frolov [mailto:v.f...@or...] > Sent: Wednesday, 27 May 2009 11:28 PM > To: opa...@li... > Subject: Re: [Opalvoip-devel] [Opalvoip-user] OPAL v3.6.1 -> v3.6.2 > API change > > https://sourceforge.net/tracker/?func=detail&aid=2797380&group_id=204 > 472&atid=989750 > > In the OPAL v3.6.2 and TRUNK the following H.323 code was removed: > > 1) code that do mode change on receiving RequestModeChangeAck; > 2) RequestModeChangeT38 method that used in t38modem v1.1.0 (already > released for OPAL v3.6). > > The h323neg.patch fixes (1). > The h323con.patch fixes (2). > > The pathes done for opal/branches/v3_6/ but IMO > at least h323neg.patch should be applied to TRUNK too. > > > Craig Southeren wrote: > > > Vyacheslav Frolov wrote: > > > >> The RequestModeChangeT38 was removed from OPAL v3.6.2. > >> > >> Is it normal for OPAL project to change API in minor versions? > > > > > > Only when absolutely necessary to fix a bug or remove a problem > > > > Craig > > > > > > ********************************************************************* > ********************************** > This message and any attachments (the "message") are confidential and > intended solely for the addressees. > Any unauthorised use or dissemination is prohibited. > Messages are susceptible to alteration. Orange Business Services > shall not be liable for the message if altered, changed or > falsified. If you are not the intended addressee of this message, > please cancel it immediately and inform > the sender. > ********************************************************************* > ********************************** > > --------------------------------------------------------------------- > --------- > Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT > is a gathering of tech-side developers & brand creativity > professionals. Meet > the minds behind Google Creative Lab, Visual Complexity, Processing, > & > iPhoneDevCamp as they present alongside digital heavyweights like > Barbarian > Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com > _______________________________________________ > Opalvoip-devel mailing list > Opa...@li... > https://lists.sourceforge.net/lists/listinfo/opalvoip-devel |