OpalVOIP / Bugs / #419 'make' calls 'configure' when it should not

#419 'make' calls 'configure' when it should not

Milestone: Development_Branch

Status: closed-works-for-me

Owner: nobody

Labels: None

Priority: 5

Updated: 2013-03-11

Created: 2013-02-02

Creator: Anonymous

Private: No

The program 'make' runs the 'configure' script in circumstances when it should not, such as:
make clean
or when configure has already been run.
The fact that configure is rerun by make when configure has already been run causes the previously performed configuration to be ignored.

Discussion

Craig Southeren - 2013-02-02

A lot of bugs in this area have been fixed in recent weeks. configure should only be called if configure.ac or one of the dependent config files have been changed.

We'll need to know what version of the code shows this problem.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Markus Elfring - 2013-02-06

I saw also such unexpected behaviour from Eridani.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Craig Southeren - 2013-02-06

If configure is re-run automatically, it will use the previous settings via "./config.status --config", so no settings should be lost.

If settings are being lost, please provide an example use case so we can duplicate and fix.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Craig Southeren - 2013-02-06

status: open --> pending-works-for-me
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Markus Elfring - 2013-02-09

Can it be that the current build dependencies are incomplete because the "main" make file ("TOP_LEVEL_MAKE") was changed in a way so that it can not be correctly regenerated by the autoconf build specification?
https://sourceforge.net/tracker/?func=detail&atid=989748&aid=3603530&group_id=204472

http://opalvoip.svn.sourceforge.net/viewvc/opalvoip/ptlib/tags/v2_12_0/make/toplevel.mak?revision=28487&view=markup

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Markus Elfring - 2013-02-09

status: pending-works-for-me --> open-works-for-me
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

kiri - 2013-02-12

I tested whether 'make' changed configuration options in tags/v2_12_0 and trunk.
In v2_12_0 , configuration selections were not retained. In trunk they are.

It would still be an improvement if 'make' can be made to not to reconfigure.
Perhaps that is due a separate issue in the tracker though.
Not retaining configure selections I would classify as a 'bug'.
Not calling configure unnecessarily I classify as a 'feature request'.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Markus Elfring - 2013-02-12

Could you regenerate a main make file ("TOP_LEVEL_MAKE") for the "trunk" version in your test?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Robert Jongbloed - 2013-02-14

This was fixed a few weeks ago, are you using latest SVN?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Robert Jongbloed - 2013-02-14

status: open-works-for-me --> pending-works-for-me
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Markus Elfring - 2013-02-14

No. - I referred to the version "2.12.0".

But I see that the current build specification might be affected by an open issue in the design. Why do you store "Makefiles" in your source file repository?
Do the Autotools belong to your essential build system?

Would you like to integrate the following update suggestion?

Index: configure.ac

--- configure.ac (Revision 29011)
+++ configure.ac (Arbeitskopie)
@@ -2159,9 +2159,9 @@
fi
dnl end of test for video

- AC_CONFIG_FILES(plugins/Makefile)
- AC_CONFIG_FILES(plugins/vidinput_v4l2/Makefile)
- AC_CONFIG_FILES(plugins/vidinput_dc/Makefile)
+ AC_CONFIG_FILES([plugins/Makefile
+ plugins/vidinput_v4l2/Makefile
+ plugins/vidinput_dc/Makefile])

fi # enable_plugins

@@ -2180,9 +2180,10 @@

AC_PROG_INSTALL

-AC_CONFIG_FILES(ptlib.pc)
-AC_CONFIG_FILES(ptlib_cfg.dxy)
-AC_CONFIG_FILES(make/ptbuildopts.mak)
+AC_CONFIG_FILES([Makefile
+ ptlib.pc
+ ptlib_cfg.dxy
+ make/ptbuildopts.mak])

dnl ########################################################################
dnl output header file

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Markus Elfring - 2013-02-14

status: pending-works-for-me --> open-works-for-me
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Robert Jongbloed - 2013-03-11

status: open-works-for-me --> closed-works-for-me

milestone: --> Development_Branch
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.