#411 Check building of plug-in "vidinput_avc"

Stable_Branch
closed-accepted
PTLib (141)
5
2013-01-30
2013-01-13
Markus Elfring
No

I try to generate your current stable library on my openSUSE Tumbleweed system.
http://www.opalvoip.org/wiki/index.php?n=Main.VersionNumbering

I stumble on the following open issues.

elfring@Sonne:~/Projekte/OpalVoip/ptlib/2.12> LANG=C make -j8
...
make[4]: Entering directory `/home/elfring/Projekte/OpalVoip/ptlib/2.12/plugins/vidinput_avc'
[CC] vidinput_avc.cxx
In file included from vidinput_avc.cxx:65:0:
vidinput_avc.h:131:9: error: conflicting return type specified for 'virtual int PVideoInputDevice_1394AVC::GetBrightness()'
In file included from vidinput_avc.h:48:0,
from vidinput_avc.cxx:65:
/home/elfring/Projekte/OpalVoip/ptlib/2.12/include/ptlib/videoio.h:668:5: error: overriding 'virtual ptlib_virtual_function_changed_or_removed****** PVideoDevice::GetBrightness()'
In file included from vidinput_avc.cxx:65:0:
vidinput_avc.h:135:14: error: conflicting return type specified for 'virtual PBoolean PVideoInputDevice_1394AVC::SetBrightness(unsigned int)'
In file included from vidinput_avc.h:48:0,
from vidinput_avc.cxx:65:
/home/elfring/Projekte/OpalVoip/ptlib/2.12/include/ptlib/videoio.h:669:5: error: overriding 'virtual ptlib_virtual_function_changed_or_removed****** PVideoDevice::SetBrightness(unsigned int)'
In file included from vidinput_avc.cxx:65:0:
vidinput_avc.h:140:9: error: conflicting return type specified for 'virtual int PVideoInputDevice_1394AVC::GetWhiteness()'
In file included from vidinput_avc.h:48:0,
from vidinput_avc.cxx:65:
/home/elfring/Projekte/OpalVoip/ptlib/2.12/include/ptlib/videoio.h:670:5: error: overriding 'virtual ptlib_virtual_function_changed_or_removed****** PVideoDevice::GetWhiteness()'
In file included from vidinput_avc.cxx:65:0:
vidinput_avc.h:144:14: error: conflicting return type specified for 'virtual PBoolean PVideoInputDevice_1394AVC::SetWhiteness(unsigned int)'
In file included from vidinput_avc.h:48:0,
from vidinput_avc.cxx:65:
/home/elfring/Projekte/OpalVoip/ptlib/2.12/include/ptlib/videoio.h:671:5: error: overriding 'virtual ptlib_virtual_function_changed_or_removed****** PVideoDevice::SetWhiteness(unsigned int)'
In file included from vidinput_avc.cxx:65:0:
vidinput_avc.h:149:9: error: conflicting return type specified for 'virtual int PVideoInputDevice_1394AVC::GetColour()'
In file included from vidinput_avc.h:48:0,
from vidinput_avc.cxx:65:
/home/elfring/Projekte/OpalVoip/ptlib/2.12/include/ptlib/videoio.h:672:5: error: overriding 'virtual ptlib_virtual_function_changed_or_removed****** PVideoDevice::GetColour()'
In file included from vidinput_avc.cxx:65:0:
vidinput_avc.h:153:14: error: conflicting return type specified for 'virtual PBoolean PVideoInputDevice_1394AVC::SetColour(unsigned int)'
In file included from vidinput_avc.h:48:0,
from vidinput_avc.cxx:65:
/home/elfring/Projekte/OpalVoip/ptlib/2.12/include/ptlib/videoio.h:673:5: error: overriding 'virtual ptlib_virtual_function_changed_or_removed****** PVideoDevice::SetColour(unsigned int)'
In file included from vidinput_avc.cxx:65:0:
vidinput_avc.h:158:9: error: conflicting return type specified for 'virtual int PVideoInputDevice_1394AVC::GetContrast()'
In file included from vidinput_avc.h:48:0,
from vidinput_avc.cxx:65:
/home/elfring/Projekte/OpalVoip/ptlib/2.12/include/ptlib/videoio.h:674:5: error: overriding 'virtual ptlib_virtual_function_changed_or_removed****** PVideoDevice::GetContrast()'
In file included from vidinput_avc.cxx:65:0:
vidinput_avc.h:162:14: error: conflicting return type specified for 'virtual PBoolean PVideoInputDevice_1394AVC::SetContrast(unsigned int)'
In file included from vidinput_avc.h:48:0,
from vidinput_avc.cxx:65:
/home/elfring/Projekte/OpalVoip/ptlib/2.12/include/ptlib/videoio.h:675:5: error: overriding 'virtual ptlib_virtual_function_changed_or_removed****** PVideoDevice::SetContrast(unsigned int)'
In file included from vidinput_avc.cxx:65:0:
vidinput_avc.h:167:9: error: conflicting return type specified for 'virtual int PVideoInputDevice_1394AVC::GetHue()'
In file included from vidinput_avc.h:48:0,
from vidinput_avc.cxx:65:
/home/elfring/Projekte/OpalVoip/ptlib/2.12/include/ptlib/videoio.h:676:5: error: overriding 'virtual ptlib_virtual_function_changed_or_removed****** PVideoDevice::GetHue()'
In file included from vidinput_avc.cxx:65:0:
vidinput_avc.h:171:14: error: conflicting return type specified for 'virtual PBoolean PVideoInputDevice_1394AVC::SetHue(unsigned int)'
In file included from vidinput_avc.h:48:0,
from vidinput_avc.cxx:65:
/home/elfring/Projekte/OpalVoip/ptlib/2.12/include/ptlib/videoio.h:677:5: error: overriding 'virtual ptlib_virtual_function_changed_or_removed****** PVideoDevice::SetHue(unsigned int)'
In file included from vidinput_avc.cxx:65:0:
vidinput_avc.h:176:14: error: conflicting return type specified for 'virtual PBoolean PVideoInputDevice_1394AVC::GetParameters(int*, int*, int*, int*, int*)'
In file included from vidinput_avc.h:48:0,
from vidinput_avc.cxx:65:
/home/elfring/Projekte/OpalVoip/ptlib/2.12/include/ptlib/videoio.h:678:5: error: overriding 'virtual ptlib_virtual_function_changed_or_removed****** PVideoDevice::GetParameters(int*, int*, int*, int*, int*)'
vidinput_avc.cxx: In member function 'virtual PBoolean PVideoInputDevice_1394AVC::Start()':
vidinput_avc.cxx:166:57: error: 'raw1394_set_iso_handler' was not declared in this scope
vidinput_avc.cxx: In member function 'virtual PBoolean PVideoInputDevice_1394AVC::GetFrameDataNoDelay(BYTE*, PINDEX*)':
vidinput_avc.cxx:374:39: error: 'raw1394_start_iso_rcv' was not declared in this scope
vidinput_avc.cxx:381:22: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
vidinput_avc.cxx:418:34: error: 'raw1394_stop_iso_rcv' was not declared in this scope
...

Discussion

  • Unfortunately, there seems to have been an API change in the system
    libraries to support these camera grabbers. So they have been disabled
    until someone has time to fix them.

    Even more unfortunately, no one I know within the project has any knowledge
    in this area. The person that wrote them has long since left. So, unless
    you wish to pitch in and help, it could be some time until they are fixed.

     
    • status: open --> pending-wont-fix
     
  • Markus Elfring
    Markus Elfring
    2013-01-22

    I hope that such API breakage can be detected earlier. Will any corresponding fine-tuning be added?

    Can unmaintained plug-ins be excluded from the software compilation by specific configuration options?

     
  • Markus Elfring
    Markus Elfring
    2013-01-22

    • status: pending-wont-fix --> open-wont-fix
     
  • Markus Elfring
    Markus Elfring
    2013-01-28

    update suggestion

     
    Attachments
  • Markus Elfring
    Markus Elfring
    2013-01-28

    I get the source files to compile again with the appended adjustments. They show changes that will need further considerations by a constructive code review.
    I guess that some of the involved configuration parameters will also need a bit more fine-tuning.

     
  • Markus Elfring
    Markus Elfring
    2013-01-28

    • assigned_to: nobody --> rjongbloed
    • status: open-wont-fix --> open-remind
     
  • Fix applied to Eridani (PTLib 2.12, OPAL 3.12) and trunk, thank you very much!

     
    • status: open-remind --> closed-accepted