#392 Possible Bug in SIPHandler::OnTransactionFailed

Stable_Branch
closed-fixed
nobody
OPAL (214)
5
2012-11-16
2012-10-18
Anonymous
No

Hi Robert,

I found a Bug in SIPHandler::OnTransactionFailed, when the reliable transport is lost. SIPTransaction::SetTerminated removes itself from the list of active transactions of the transaction owner and then calls OnTransactionFailed. In SIPHandler::OnTransactionFailed this transaction shall be deleted again, which will fail. This causes the register thread to hang. It never terminates and I cannot detect that error.

I attached a possible patch for that.

Discussion


  • Anonymous
    2012-10-18

    Removes the transaction only if it still exists

     

  • Anonymous
    2012-10-18

    • labels: --> OPAL
    • milestone: --> Stable_Branch
     
    • status: open --> closed-fixed
     
  • Patch even simpler as m_transactions.Remove(&transaction) completely redundant.

     
  • Fix applied to Eridani (PTLib 2.12, OPAL 3.12) and trunk, thank you very much!