Revised diagram format as per recent discussions.
You seem to have CSS turned off.
Please don't fill out this field.
This patch looks okay. Actually there a few minor things I'd like changed, but I'll bring that up later.
The main problem is the patch won't apply. You need to start the patch from the root of your checked out working copy. Or at least a higher directory.
I can't tell you exactly how to do that, because I don't know how you have things checked out. It would be ideal to start at the level in your working copy that corresponds to:
If you do that, the top of the diff will look like this:
C:\work.ooRexx\wc\docs>svn diff oodialog\en-US\baseClasses.xml
--- oodialog/en-US/baseClasses.xml (revision 9012)
+++ oodialog/en-US/baseClasses.xml (working copy)
Note the Index has the path from my top level directory to the file in the lower level directory.
the --- line has oodialog/en-US/baseClasses.ml
the +++ line also has the path.
Sorry, Staffan, I see that your patch does start from the higher directory. I'll have to look at it again to see why it didn't apply.
Staffan, the patch does apply fine, sorry for the confusion.
This is either applied, or we have moved on past this.