#221 FileNameDialog \\\"multi\\\"

v3.2.0
closed
Mark Miesfeld
5
2012-08-14
2007-08-13
Lee Peedin
No

Since L & S can now be used to represent LOAD/SAVE, request that M be allowed to represent MULTT.

In reviewing the code for the L/S modification, I believe this can be done by changing the following line in oodutils.cls in the FileNameDialog routine

Existing Code:
if load == 1 & amulti~translate = "MULTI" then amulti = 1; else amulti = 0

Proposed modification:
if load == 1 & (amulti~translate = "MULTI" | amulti~translate = "M") then amulti = 1; else amulti = 0

Discussion

  • Mark Miesfeld
    Mark Miesfeld
    2007-08-13

    Logged In: YES
    user_id=191588
    Originator: NO

    Lee,

    That seems reasonable to me and in keeping with many other places in ooRexx where only the first letter of an option is required.

    In most other places where the first letter of an option is accepted, only the first letter is checked. I think this would be a good implementation:

    if load == 1 & amulti~left(1)~translate = "M" then amulti = 1; else amulti = 0

    My intent is to implement this. I'll wait for 2 days before I commit the code to give others the chance to comment if they wish.

     
  • Lee Peedin
    Lee Peedin
    2007-08-13

    Logged In: YES
    user_id=1223125
    Originator: YES

    Mark,
    Your solution of only checking the first letter sounds good to me. I also like the idea of letting this stay open for a couple of days for any additional discussion.

    Lee

     
  • Aviatrexx
    Aviatrexx
    2007-08-14

    Logged In: YES
    user_id=363279
    Originator: NO

    Sounds good to me.

    I know you were waiting to hear that. :-)

    -Chip-

     
  • Mark Miesfeld
    Mark Miesfeld
    2007-08-18

    Logged In: YES
    user_id=191588
    Originator: NO

    Committed revision 685.
    Committed revision 686.

    Commit 685 relaxes the check for the multiSelection argument so that only the first letter 'M' is needed.

    Commit 686 updates the ooDialog documentation to reflect the change.

     


Anonymous


Cancel   Add attachments