#869 ooDialog internal logic wrong on failed dialog creation

Mark Miesfeld
ooDialog (58)
Mark Miesfeld

In ooDialog, when there is a failure to create the underlying Windows dialog, there is some clean up of the internal data structures that needs to be down. (At this time namely the DIALOGADMIN block.)

The logic in this area is incorrect, it actually deletes the data structures of the previously created dialog, and fails to delete the data structures of failed dialog. If only one dialog has been created, there is no way for the user to see this error. But, if two dialogs are created in a row, with the second dialog having an error, the the first dialog is destroyed. This of course makes it easy to see that something is wrong.

The attached program demonstrates this error on 3.2.0


  • Mark Miesfeld
    Mark Miesfeld

    This is fixed in trunk, fixed durning the refactoring of ooDialog.

    The demonstration program runs correctly under an ooRexx built from trunk.

  • Mark Miesfeld
    Mark Miesfeld

    This fix will be in the next major release of ooDialog, but not in the ooRexx 4.1.0 release.

  • Mark Miesfeld
    Mark Miesfeld

    This fix will appear in the next major release of ooDialog, it will not be included in an ooRexx bug fix release



Cancel   Add attachments